Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update APIKey suppliedIn docs #7084

Merged
merged 1 commit into from
Jan 8, 2025
Merged

update APIKey suppliedIn docs #7084

merged 1 commit into from
Jan 8, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 8, 2025 •
edited
Loading

Proposed changes

Fix APIKey Policy docs to highlight that suppliedIn is a mandatory parameter.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested review from a team as code owners January 8, 2025 15:53
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jan 8, 2025
@pdabelf5 pdabelf5 self-assigned this Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7084/

@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Jan 8, 2025
@pdabelf5 pdabelf5 merged commit 22a6f8c into main Jan 8, 2025
30 checks passed
@pdabelf5 pdabelf5 deleted the apikey-docs branch January 8, 2025 16:33
nginx-bot pushed a commit that referenced this pull request Jan 8, 2025
@pdabelf5 @web-flow
update APIKey suppliedIn docs (#7084)
2523bc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @haywoodsh @vepatel @AlexFenlon